Bug: show_navigation_icon: false is filtered out in TopBar::toNativeProps() - #162
Merged
Conversation
…rops()
The toNativeProps() method in TopBar uses array_filter with fn ($value) => $value !== null && $value !== false, which silently drops boolean false values before sending props to the native layer. This
makes it impossible to disable show_navigation_icon — the prop is never transmitted, so the native side always falls back to its default (showing the icon).
Fix: align the filter with SideNavHeader, which correctly uses fn ($value) => $value !== null.
// Before
], fn ($value) => $value !== null && $value !== false);
// After
], fn ($value) => $value !== null);
Reproducible with:
<native:top-bar title="Test" :show-navigation-icon="false" />
{{-- hamburger still visible despite false --}}
JeremieMercier
changed the title
Member
|
@JeremieMercier could you resolve the conflicts? |
Author
|
@simonhamp I modified the source branch because the TopBar.php file was removed in the main branch with version 4 of NativePHP. |
Member
|
Thanks so much for the work you've put into this PR. Now that we're pushing towards fully native UI through SuperNative, PRs that target v3 or below should focus purely on bug fixes and security patches. So I'm going to close this one. |
Member
|
Sorry, my bad. This is a bugfix |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The toNativeProps() method in TopBar uses array_filter with fn ($value) => $value !== null && $value !== false, which silently drops boolean false values before sending props to the native layer. This
makes it impossible to disable show_navigation_icon — the prop is never transmitted, so the native side always falls back to its default (showing the icon).
Fix: align the filter with SideNavHeader, which correctly uses fn ($value) => $value !== null.
// Before
], fn ($value) => $value !== null && $value !== false);
// After
], fn ($value) => $value !== null);
Reproducible with:
<native:top-bar title="Test" :show-navigation-icon="false" />
{{-- hamburger still visible despite false --}}